Global Styles: Include spacing rules as part of typography variations #62709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
|
Size Change: +22 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
force-pushed
the
add/spacing-to-typography-presets
branch
2 times, most recently
from
57863af to
975f079
Compare
|
There was some concern about the approach here - does it make sense to make this exception? Can we find/create other tools within typography that gives us the same thing? |
scruffian
force-pushed
the
add/spacing-to-typography-presets
branch
from
975f079 to
cb2b4bd
Compare
update variables add filtering to the default variation add spacing to variation
scruffian
force-pushed
the
add/spacing-to-typography-presets
branch
from
cb2b4bd to
bf2f26a
Compare
|
I'm not convinced this is a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Includes spacing as part of typography presets. Fixes #61214.
Why?
Spacing is an important part of typography styles, so we should treat these rules as part of the typography variation.
How?
Several functions have been expanded to take an array of properties rather than a single property:
useCurrentMergeThemeStyleVariationsWithUserConfigisVariationWithSingleProperty->isVariationWithPropertiesfilterObjectByProperty->filterObjectByPropertiesremovePropertyFromObject->removePropertiesFromObjectTesting Instructions
Screenshots or screencast