Keep an inserted pattern within view when added to the page #62700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 7d90c9e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9597218771
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@akasunil is this still relevant? I'm seeing this behavior in trunk already: CleanShot.2024-07-12.at.20.10.06.mp4 |
|
@richtabor Yes, it works fine now in latest trunk. I'll close the PR. |
|
Closing this out as issue is already fixed in latest trunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #59962
Why?
Currently, when we add a pattern via the Inserter, the pattern is added to the bottom of the page and cannot be seen. This PR resolves the issue and makes the pattern visible on insert, allowing the user to see the newly added pattern.
Testing Instructions
Screenshots or screencast
Edit-Post-.Pattern-Test.-.-gutenberg-.-WordPress.mp4