Editor: make VisualEditor a stacking context #62681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +16 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
t-hamano
added
the
Backport to WP 6.7 Beta/RC
t-hamano
reviewed
Jun 20, 2024
There was a problem hiding this comment.
This PR is working as expected. Also, as far as I tested, there are no other issues caused by this PR.
Before
After
However, the next release this PR will be backported is RC version, and to be on the safe side, I would like to ask for a second review by people who are knowledgeable in this area 🙏
youknowriad
reviewed
Jun 20, 2024
| @@ -3,6 +3,8 @@ | |||
| height: 100%; | |||
| display: block; | |||
| background-color: $gray-300; | |||
| // Make this a stacking context to contain the z-index of children elements. | |||
| isolation: isolate; | |||
There was a problem hiding this comment.
😬 I just learned about this
There was a problem hiding this comment.
😬 I just learned about this
And yet you used the property here 😆
There was a problem hiding this comment.
I know I know, that's where I saw it first. I copied it form the View Transition Guide (by Google) to reset cross-shadow transitions :P
|
Seems ok to me but I wonder what impact this change can have. (other z-index related impact) |
|
Personally, I think this issue is less serious. Would it be better to test it only on Gutenberg for now and not backport it to WP 6.6? |
I’m all for making haste slowly. The property could have been on the
They are all probably expected to be no higher than the visual editor itself and seem to work as expected. Any popover launched from those is out in the fallback container as are any other popovers I've found in the interface so can’t be affected by this change. |
t-hamano
approved these changes
Jun 24, 2024
|
@stokesman I think it would be better to merge this PR without the backport label just to be safe. What do you think? |
|
It’s fine by me. Is there a chance to still fix the issue in 6.6? If not by backporting this later then perhaps a PR which fixes it by changing z-index? I know the issue isn’t critical but it’d be nice have it done. |
|
Sure it's fine, but needs to be merged asap, we're cherrypicking rn |
t-hamano
force-pushed
the
update/visual-editor-stacking-context
branch
from
826b008 to
8937f9d
Compare
|
It seemed like GitHub Actions had stopped, so I rebased it to get it running again. |
|
Flaky tests detected in 8937f9d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9660133699
|
gutenbergplugin
pushed a commit
that referenced
this pull request
Jun 25, 2024
Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 349a36d |
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
@stokesman Maybe this PR caused an issue with popovers. Is there a way to fix this? Please see #62998 |
This was referenced Jul 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A change to
VisualEditorso it contains z-indexes of children within it (as a stacking context)Why?
To fix #62639, in which it’s noted that the block toolbar is not actually underneath the editor header and so the header’s shadow disappears behind it.
How?
Add
isolation: isolateto the component’s root element.Testing Instructions