Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Add style variation partial cache #62610

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add backport file
oandregal committed Jun 19, 2024
commit 72f8a824bcd57a35cf8f4c3d542a89cad72bc3bd
3 changes: 3 additions & 0 deletions backport-changelog/6.6/6857.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
https://github.com/WordPress/wordpress-develop/pull/6857

* https://github.com/WordPress/gutenberg/pull/62610

Unchanged files with check annotations Beta

// Make sure the items have loaded before reaching for the 1st item in the list.
await expect( page.getByRole( 'grid' ) ).toBeVisible();
await page.keyboard.press( 'Tab' );
await expect( page.getByLabel( 'Privacy Policy' ) ).toBeFocused();

Check failure on line 76 in test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js

GitHub Actions / Playwright - 5

[chromium] › site-editor/dataviews-list-layout-keyboard.spec.js:62:2 › Dataviews List Layout › Navigates from items list to preview via TAB

1) [chromium] › site-editor/dataviews-list-layout-keyboard.spec.js:62:2 › Dataviews List Layout › Navigates from items list to preview via TAB, and vice versa Error: Timed out 5000ms waiting for expect(locator).toBeFocused() Locator: getByLabel('Privacy Policy') Expected: focused Received: inactive Call log: - expect.toBeFocused with timeout 5000ms - waiting for getByLabel('Privacy Policy') - locator resolved to <div role="button" tabindex="-1" id="view-list-0-184"…>…</div> - unexpected value "not focused" - locator resolved to <div role="button" tabindex="-1" id="view-list-0-184"…>…</div> - unexpected value "not focused" - locator resolved to <div role="button" tabindex="-1" id="view-list-0-184"…>…</div> - unexpected value "not focused" - locator resolved to <div role="button" tabindex="-1" id="view-list-0-184"…>…</div> - unexpected value "not focused" - locator resolved to <div role="button" tabindex="-1" id="view-list-0-184"…>…</div> - unexpected value "not focused" - locator resolved to <div role="button" tabindex="-1" id="view-list-0-184"…>…</div> - unexpected value "not focused" - locator resolved to <div role="button" tabindex="-1" id="view-list-0-184"…>…</div> - unexpected value "not focused" - locator resolved to <div role="button" tabindex="-1" id="view-list-0-184"…>…</div> - unexpected value "not focused" - locator resolved to <div role="button" tabindex="-1" id="view-list-0-184"…>…</div> - unexpected value "not focused" 74 | await expect( page.getByRole( 'grid' ) ).toBeVisible(); 75 | await page.keyboard.press( 'Tab' ); > 76 | await expect( page.getByLabel( 'Privacy Policy' ) ).toBeFocused(); | ^ 77 | 78 | // Go to the preview. 79 | await page.keyboard.press( 'Tab' ); at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js:76:55
// Go to the preview.
await page.keyboard.press( 'Tab' );