Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font size presets UI #62328

Closed
wants to merge 41 commits into from
Closed

Font size presets UI #62328

wants to merge 41 commits into from

Commits on Jun 5, 2024

  1. move font size picker custom control to a new component

    @matiasbenedetto
    matiasbenedetto committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    b8e83e3 View commit details
    Browse the repository at this point in the history

  2. move props to the inner component

    @matiasbenedetto
    matiasbenedetto committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    107ea70 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. renaming and moving the custom size control to its own folder

    @matiasbenedetto
    matiasbenedetto committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    4d55771 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. implement font size management UI

    @matiasbenedetto
    matiasbenedetto committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    19307c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. re-use getNewIndexFromPresets

    @matiasbenedetto
    matiasbenedetto committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    8465ece View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. tooltip text

    @matiasbenedetto
    matiasbenedetto committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a3a97d9 View commit details
    Browse the repository at this point in the history

  2. update wording

    @matiasbenedetto
    matiasbenedetto committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0b6c490 View commit details
    Browse the repository at this point in the history

  3. replace Spacer components by VStack

    @matiasbenedetto
    matiasbenedetto committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    239b781 View commit details
    Browse the repository at this point in the history

  4. remove reset buttons

    @matiasbenedetto
    matiasbenedetto committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    647ff41 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. add base control to size control

    @matiasbenedetto
    matiasbenedetto committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    82223d9 View commit details
    Browse the repository at this point in the history

  2. use useBaseControlProps

    @matiasbenedetto
    matiasbenedetto committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9e05bac View commit details
    Browse the repository at this point in the history

  3. use toggle control

    @matiasbenedetto
    matiasbenedetto committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    429fbec View commit details
    Browse the repository at this point in the history

  4. update class names

    @matiasbenedetto
    matiasbenedetto committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    45de557 View commit details
    Browse the repository at this point in the history

  5. update wording

    @matiasbenedetto
    matiasbenedetto committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    fb2f13c View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. normalize and order font sizes. Add styles to avoid multi-line

    @matiasbenedetto
    matiasbenedetto committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3144e78 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into add/font-size-presets-ui

    @matiasbenedetto
    matiasbenedetto committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    1601b57 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. remove tooltip 

    Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
    @matiasbenedetto @t-hamano
    matiasbenedetto and t-hamano authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    060826f View commit details
    Browse the repository at this point in the history

  2. fix comment 

    Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
    @matiasbenedetto @t-hamano
    matiasbenedetto and t-hamano authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    9a68e97 View commit details
    Browse the repository at this point in the history

  3. remove style accidentally added with merging trunk branch

    @matiasbenedetto
    matiasbenedetto committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    73617a8 View commit details
    Browse the repository at this point in the history

  4. fix mispelled words in labels

    @matiasbenedetto
    matiasbenedetto committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    0c8ecde View commit details
    Browse the repository at this point in the history

  5. add control style props

    @matiasbenedetto
    matiasbenedetto committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    55d4b40 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'trunk' into add/font-size-presets-ui

    @matiasbenedetto
    matiasbenedetto committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1b021cc View commit details
    Browse the repository at this point in the history

  7. undo readme link change

    @matiasbenedetto
    matiasbenedetto committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f07b87e View commit details
    Browse the repository at this point in the history

  8. empty array as fallback value

    @matiasbenedetto
    matiasbenedetto committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    92d9264 View commit details
    Browse the repository at this point in the history

  9. removes the reset related logic

    @matiasbenedetto
    matiasbenedetto committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    cc582db View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. adding __nextHasNoMarginBottom to ToggleControl components 

    Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
    @matiasbenedetto @t-hamano
    matiasbenedetto and t-hamano authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    c42f120 View commit details
    Browse the repository at this point in the history

  2. adding confirm dialog to remove font size

    @matiasbenedetto
    matiasbenedetto committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b8c4dfa View commit details
    Browse the repository at this point in the history

  3. add rename modal

    @matiasbenedetto
    matiasbenedetto committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a9b0d2c View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. polish props definition

    @matiasbenedetto
    matiasbenedetto committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c59899e View commit details
    Browse the repository at this point in the history

  2. simplify the component and fix the use of id prop

    @matiasbenedetto
    matiasbenedetto committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e82cee4 View commit details
    Browse the repository at this point in the history

  3. add story for the SizeControl component

    @matiasbenedetto
    matiasbenedetto committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ec3b35a View commit details
    Browse the repository at this point in the history

  4. name export

    @matiasbenedetto
    matiasbenedetto committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cf56e16 View commit details
    Browse the repository at this point in the history

  5. improve naming

    @matiasbenedetto
    matiasbenedetto committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e2e3b87 View commit details
    Browse the repository at this point in the history

  6. fix defaults

    @matiasbenedetto
    matiasbenedetto committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    9b27d21 View commit details
    Browse the repository at this point in the history

  7. improving storybook

    @matiasbenedetto
    matiasbenedetto committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    47d0763 View commit details
    Browse the repository at this point in the history

  8. removing unwanted prop

    @matiasbenedetto
    matiasbenedetto committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cfd0619 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. add the ability to pass hasUnit as a prop

    @matiasbenedetto
    matiasbenedetto committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7bbfeac View commit details
    Browse the repository at this point in the history

  2. withReset default true

    @matiasbenedetto
    matiasbenedetto committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    62f2f20 View commit details
    Browse the repository at this point in the history

  3. tweak the defaults

    @matiasbenedetto
    matiasbenedetto committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6ce12d7 View commit details
    Browse the repository at this point in the history

  4. adding unit tests for SizeControl

    @matiasbenedetto
    matiasbenedetto committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    499a6e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Merge branch 'trunk' into add/font-size-presets-ui

    @matiasbenedetto
    matiasbenedetto committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    86df1e2 View commit details
    Browse the repository at this point in the history