Editor: Only render the site logo once if there's a fill #62320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +24 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
I can confirm that this PR works. 
Tested with: |
yansern
approved these changes
Jun 5, 2024
|
I just cherry-picked this PR to the release/18.5 branch to get it included in the next release: 803c373 |
vcanales
removed
the
Backport to Gutenberg RC
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62318
What?
Recently, we've updated the edit-post code base to use the Slot/Fill to customize the default "back button" of the
EditorInterfacecomponent. The problem is that this meant that if there was already a plugin using that slot, we'll end up with two logos or two back buttons.This PR adds the registered fills count as a fill prop, and only renders the default core provided fill if there's no extra fill registered by a plugin.
Testing Instructions
gutenberg/packages/edit-post/src/components/layout/index.js
Line 288 in a58e49b