Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Add new post" link text with more meaningful Label (v2) #62277

Merged
merged 4 commits into from
Jun 8, 2024
Merged

Replace "Add new post" link text with more meaningful Label (v2) #62277

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4096f10
Replace "Add new post" link text with more meaningful 'add_new_item' …
carstingaxion Mar 11, 2024
1632d84
Avoid rendering the CreateNewPostLink component itself if postType is…
carstingaxion Jun 4, 2024
0c1cf66
Follow recommendation to use useSelect hook, instead of using select(…
carstingaxion Jun 4, 2024
59a7a28
Merge branch 'trunk' into feature/better-create-new-post-link-v2
carstingaxion Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/block-library/src/query/edit/inspector-controls/create-new-post-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
/**
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';
import { createInterpolateElement } from '@wordpress/element';
import { addQueryArgs } from '@wordpress/url';
import { store as coreStore } from '@wordpress/core-data';
import { useSelect } from '@wordpress/data';

const CreateNewPostLink = ( {
attributes: { query: { postType } = {} } = {},
} ) => {
if ( ! postType ) {
return null;
}
const CreateNewPostLink = ( { postType } ) => {
const newPostUrl = addQueryArgs( 'post-new.php', {
post_type: postType,
} );

const addNewItemLabel = useSelect(
( select ) => {
const { getPostType } = select( coreStore );
return getPostType( postType )?.labels?.add_new_item;
},
[ postType ]
);
return (
<div className="wp-block-query__create-new-link">
{ createInterpolateElement(
__( '<a>Add new post</a>' ),
'<a>' + addNewItemLabel + '</a>',
// eslint-disable-next-line jsx-a11y/anchor-has-content
{ a: <a href={ newPostUrl } /> }
) }
Expand Down
8 changes: 5 additions & 3 deletions packages/block-library/src/query/edit/inspector-controls/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,11 @@ export default function QueryInspectorControls( props ) {

return (
<>
<BlockInfo>
<CreateNewPostLink { ...props } />
</BlockInfo>
{ !! postType && (
<BlockInfo>
<CreateNewPostLink postType={ postType } />
</BlockInfo>
) }
{ showSettingsPanel && (
<PanelBody title={ __( 'Settings' ) }>
{ showInheritControl && (
Expand Down
Loading