-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Media Text Block Issue : When crop image to fill is enabled, the image in nested media & text blocks does not show #62182
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
To be on the safe side, I think it's better to apply this approach to all selectors that have the .is-image-fill
class, which should be three in total.
@t-hamano Thanks for the feedback. I have implemented the suggestions, please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…e image in nested media & text blocks does not show (WordPress#62182) * Fixed Media Text Block Issue * Implemented the suggestions Co-authored-by: narenin <narenin@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
Should this be backported for WP 6.6? If so, please add the |
This issue isn't new to WP6.6, but I think it's a great fix, so let's backport it to WP6.6. |
…e image in nested media & text blocks does not show (#62182) * Fixed Media Text Block Issue * Implemented the suggestions Co-authored-by: narenin <narenin@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
…e image in nested media & text blocks does not show (#62182) * Fixed Media Text Block Issue * Implemented the suggestions Co-authored-by: narenin <narenin@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
…e image in nested media & text blocks does not show (WordPress#62182) * Fixed Media Text Block Issue * Implemented the suggestions Co-authored-by: narenin <narenin@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
This was cherry-picked to the wp/6.6 branch. |
What?
Fix: #62166
When the media & text block has an image (or featured image), and the setting "Crop image to fill" is enabled,
and another media & text block is added in the content area, the image of that second media & text block is hidden. It is hidden by the CSS from the first (outer) media & text block.
Why?
This will fixed the issue which occur when crop image to fill is enabled, the image in nested media & text blocks.
How?
I have resolved this by adding
>
to the relevant CSS selectors.Testing Instructions