Link Control: Fix focus handlers in development mode #62141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
May 30, 2024
|
@ellatrix, yes, it's a similar scenario. Here's the cycle:
The last two runs only happen in development mode to ensure that effect callbacks are pure. I used separate effect because effect also reacts to state change, and we don't want that to affect the TL;DR: If the component tracks the mounting state, it should also reset it on unmount. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
the
props-bot
github-actions
bot
removed
the
props-bot
jeryj
approved these changes
May 30, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #62089.
Related #61943.
PR fixes the
LinkControlcomponent's auto-focus handler and allows users to edit the linked text in development mode when the popover is rendered.Why?
isMountingis true.isMountingis false, and focus logic is invoked.How?
Move the component's
isMountingstate synchronization into a separate effect and add a cleanup method.Testing Instructions
The following e2e test should pass in development mode, and CI checks should be green. See the original issue for enabling the dev mode.
Testing Instructions for Keyboard
Same.