Editor: Align the Post Format control design with the rest of the post sidebar controls #62066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t sidebar controls
youknowriad
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +549 B (+0.03%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
jeryj
changed the title
|
To avoid introducing too many extra clicks I think ideally we'd move to something more like the Status dialog, IE radios rather than a select. I appreciate that might be a detail to work on separately though. If we keep the select for now, would it make sense to auto-focus the select when the dialog is opened? Also could it be 40px rather than 32px, to match the other Inspector inputs? |
|
I updated the dropdown to use RadioControl like the post status one. |
youknowriad
commented
May 28, 2024
|
|
||
| .editor-post-format__options { | ||
| .components-base-control__field > .components-v-stack { | ||
| gap: $grid-unit-15; |
There was a problem hiding this comment.
The gap between radio options is way too small by default in RadioControl, I wonder if this style should be something to elevate to the components package. cc @mirka
ntsekouras
reviewed
May 29, 2024
| ) } | ||
| onClick={ onToggle } | ||
| > | ||
| { activeFormat?.caption } |
There was a problem hiding this comment.
Can this be in any case not defined? I think not, but if yes, it will just render an 'empty' button here which would make no much sense, would it?
There was a problem hiding this comment.
In theory no, if you change in the UI but this is just defensive coding I guess to avoid breaking the editor if some plugin does something weird in editEntityRecord.
ntsekouras
approved these changes
May 29, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…t sidebar controls (WordPress#62066) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…t sidebar controls (WordPress#62066) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Looking at the design of the Post Format control in the post editor sidebar, it looks out of place compared to the other controls. This PR tries to bring some harmony there and just applies the same behavior we have for Post Author for instance.
Before:
After:
Testing Instructions