Block Library: Remove CSS hack for Internet Explorer 11 #62043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -200 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 28, 2024
|
Nice, thank you for your attention to detail. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #58034
Similar to #60727
What?
This PR removes the fallback CSS for IE11 present in the
@wordpress/block-librarypackage. The CSS hack for IE11 in this package is only present in the Cover block.Why?
Support for IE11 has been officially removed in WordPress 5.8. And since the Gutenberg plugin no longer supports WordPress 5.8, we can remove the fallback code for IE11.
Additionally, the
afterpseudo-element of the block is used for outlines, so this CSS hack for the cover block may have implications in the future.How?
Just removed.
Testing Instructions
This PR does not change the behavior of the Cover block, but please be sure to check that the issue fixed in #44707 is not regressing. That is, the focus outline should exactly match the size of the cover image.