Font Library Modal: Remove some contexts #62042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Code Quality
|
Size Change: +77 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
mikachan
approved these changes
May 30, 2024
There was a problem hiding this comment.
Thanks for working on this, @t-hamano! This is a great refactor, and a good step towards being able to open the font modal via the command palette.
This is working well in my testing:
- Can open and close font library modal ✅
- Fonts can be uploaded and installed successfully ✅
- Can navigate between the modal tabs ✅
- Can deactivate and delete a font successfully ✅
I noticed there were two small merge conflicts, so I've gone ahead and resolved them. Please check c25aab0 and 4911cb8 look correct. Otherwise, I think this is good to bring in!
|
Flaky tests detected in 4911cb8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9305806816
|
|
@mikachan Thanks for the review! |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
* Font Library Modal: Remove some contexts * Add unlock back to installed-fonts.js --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Font Library Modal: Remove some contexts * Add unlock back to installed-fonts.js --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #58428
What?
This PR removes the following context from the font library:
themeFontsbaseThemeFontscustomFontsfontFamiliesHasChangeshasResolvedLibrary(This was never used in the first place)Why?
Aims to remove the context completely and trigger the font library modal via the command palette.
How?
This PR is the first effort for #58428. I removed relatively simple processing from the context and implemented it ad hoc in each component.
Testing Instructions
The font library behavior should be exactly the same as before, but in particular test the following: