Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up packages build-types when cleaning types #61939

Merged
merged 5 commits into from
May 24, 2024
Merged

Clean up packages build-types when cleaning types #61939

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fdfdc1
Clean up packages build-types when cleaning types
sirreal May 24, 2024
d4e7237
Use rimraf
sirreal May 24, 2024
4d462af
Clean build-types on clean packages too
sirreal May 24, 2024
9c3e162
Add space before semicolon
sirreal May 24, 2024
da5bcc4
Oh windows
sirreal May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@
"prebuild:packages": "npm run clean:packages && lerna run build",
"build:packages": "npm run --silent build:package-types && node ./bin/packages/build.js",
"build:plugin-zip": "bash ./bin/build-plugin-zip.sh",
"clean:package-types": "tsc --build --clean",
"clean:package-types": "tsc --build --clean; rm -rf packages/*/build-types",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the order matter? Just asking because you suggested running rm -rf packages/*/build-types before this command to me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it shouldn't matter.

Copy link
Contributor

@t-hamano t-hamano May 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm -rf does not work on Windows OS. Probably not many contributors are building Gutenberg on a Windows host OS, but is there a way to change the command to work on Windows/Mac/Linux all?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that rimraf is already added as a dependency. We can use this library. This library works in a cross-platform.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I used rm -rf because I noticed it already in another script.

"clean:packages": "rimraf \"./packages/*/@(build|build-module|build-style)\"",
"dev": "npm run build:packages && concurrently \"wp-scripts start\" \"npm run dev:packages\"",
"dev:packages": "concurrently \"node ./bin/packages/watch.js\" \"tsc --build --watch\"",
Expand Down
Loading