Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Enable script debug for the test env #61929

Closed
wants to merge 1 commit into from

Conversation

Mamaduka
Copy link
Member

What?

🚧 DO NOT MERGE! 🚧

PR enables SCRIPT_DEBUG for the testing environment to catch any warnings triggered by new JSX runtime. See: #61917.

@Mamaduka Mamaduka added the [Type] Code Quality Issues or PRs that relate to code quality label May 24, 2024
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka
Copy link
Member Author

@youknowriad, @jsnajdr, we should probably use the same testing environment when enabling StrictMode. It should help us catch any possible issues with double-effect runs.

@Mamaduka Mamaduka force-pushed the try/catch-new-jsx-warnings branch from ee3dbb3 to 98d1263 Compare May 24, 2024 11:56
@Mamaduka Mamaduka closed this May 27, 2024
@Mamaduka Mamaduka deleted the try/catch-new-jsx-warnings branch May 27, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant