Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: test to check for label and skip backport changelog #61808

Merged
merged 3 commits into from
May 21, 2024
Merged

Workflows: test to check for label and skip backport changelog #61808

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
519383d
Test to check for label and skip check
ramonjd May 20, 2024
2ac0b2b
Added extra label check
ramonjd May 20, 2024
f4f5f3c
Sentence case for the label: No Core Sync Required
ramonjd May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/check-backport-changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Verify Core Backport Changlog

on:
pull_request:
types: [opened, synchronize]
types: [opened, synchronize, labeled, unlabeled]
paths:
- 'lib/**'
- '!lib/load.php'
Expand Down Expand Up @@ -31,6 +31,7 @@ jobs:
- name: 'Fetch relevant history from origin'
run: git fetch origin ${{ github.event.pull_request.base.ref }}
- name: Check CHANGELOG status
if: ${{ !contains(github.event.pull_request.labels.*.name, 'No Core sync required') }}
Copy link
Member Author

@ramonjd ramonjd May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target label could easily be "Backport from WordPress Core", but there might be other scenarios where a backport isn't required, e.g., adding gutenberg text domains to i18n translations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have multiple target labels? It would be really handy to look at "Backport from WordPress Core" too!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I'll test.

Copy link
Member Author

@ramonjd ramonjd May 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 2ac0b2b

env:
PR_NUMBER: ${{ github.event.number }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion lib/class-wp-rest-global-styles-controller-gutenberg.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* REST API: Try: bundle WP_Theme_JSON class instead of inheriting per WordPress version class
* REST API: Bundle WP_Theme_JSON class instead of inheriting per WordPress version class
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well leave this in. 😄

*
* Changes to this class should be synced to the corresponding class
* in WordPress core: src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php.
Expand Down
Loading