Command Palette: Remove unused url parameter #61783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -78 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
May 20, 2024
There was a problem hiding this comment.
LGTM 👍
✅ didAccessPatternsPage is no longer present
✅ Navigation behaves as expected
✅ Tested with a mix of classic, hybrid, and block themes
Thanks for cleaning this up @t-hamano ✨
|
@aaronrobertshaw Thanks for the review! |
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #54422
What?
This PR removes the
didAccessPatternsPageparameter added to the URL when a hybrid theme accesses the Patterns page via the command palette.Why?
From #54422:
This parameter was previously introduced to control the back button link from All Template Parts page when classic themes accessed the Patterns page in the Site Editor directly.
However, now that the Patterns page is officially exposed for all themes, this parameter is no longer used anywhere.
Testing Instructions
http://localhost:8889/wp-admin/didAccessPatternsPageparameter.http://localhost:8889/wp-admin/site-editor.php?postType=wp_template_part&postId=gutenberg-test-themes%2Femptyhybrid%2F%2Fheader&didAccessPatternsPage=1Before
before.mp4
After
after.mp4