Add page-list to blocks that needs list item wrapper

[saulirajala]

What?

Wrap core/page-list with list item wrapper when its innerBlock of core/navigation

Closes #60500

Why?

Fix for #60500. When you use page-list -block as inner block of navigation block, there will be invalid html code <ul><ul><li></li></ul></ul> -structure in the frontend.

Testing Instructions

1. Check Gutenberg PR Preview
2. Inspect the navigation in header. It has <ul><li><ul><li></li></ul></li></ul> -structure, which is valid html

Screenshots

Before

After

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: saulirajala <saulirajala@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @saulirajala! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[saulirajala]

Hey @ajitbohra 👋 Any change to get this fixed before WP6.7 release?

[getdave]

@saulirajala Thanks you for the PR and for your diligence in updating it in line with changes for WP 6.7. I've requested reviews from a few folk familiar with the block so hopefully we can get some reviews soon.

[talldan]

Thanks for making the PR, sorry for the delay in anyone getting back to you. In terms of the solution, I think it might be better to go the other way, and remove the <ul> from page lists when in a navigation block.

Page List's use case in the navigation block is a quick way to add a set of navigation links, and any other individual navigation links added alongside it should appear visually as the same set of links, and also be that way in terms of the HTML hierarchy. (IMO)

It looks like there's precedence for this, as if you add Page List in a submenu alongside a custom link, it already works that way, the <ul> tag is removed from page list. It's controlled by this isNested attribute:

gutenberg/packages/block-library/src/page-list/index.php

Line 266 in 5513d7a

$is_nested = $attributes['isNested'];

Here's where it's determined. It might be a simple adjustment to make this work:

gutenberg/packages/block-library/src/page-list/edit.js

Lines 264 to 280 in 5513d7a

	const blockParents = getBlockParentsByBlockName(
	clientId,
	'core/navigation-submenu',
	true
	);
	const navigationBlockParents = getBlockParentsByBlockName(
	clientId,
	'core/navigation',
	true
	);
	return {
	isNested: blockParents.length > 0,
	isChildOfNavigation: navigationBlockParents.length > 0,
	hasSelectedChild: hasSelectedInnerBlock( clientId, true ),
	hasDraggedChild: hasDraggedInnerBlock( clientId, true ),
	parentClientId: navigationBlockParents[ 0 ],
	};

@draganescu's PR #46414 implemented that, so Andrei might have some advice.

[getdave]

@saulirajala Do you feel you would have time to make the adjustments here? No rush but wanted to check as it's on my radar to keep track of. Thank you.