Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Replace/old custom select control with v2 legacy adapter #61272

Closed
wants to merge 19 commits into from
Closed

Components: Replace/old custom select control with v2 legacy adapter #61272

wants to merge 19 commits into from

Commits on May 27, 2024

  1. Replace old CustomSelectControl select control with the V2 legacy a… 

    …dapter and fix selectedItem handling `onChange`
    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    cc17f9f View commit details
    Browse the repository at this point in the history

  2. Fix option handling logic for legacy adater and update test to reflec… 

    …t the option with custom property scenario
    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    33bb57d View commit details
    Browse the repository at this point in the history

  3. Remove debug code

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    f2c059c View commit details
    Browse the repository at this point in the history

  4. Debug why selectedItem is not selected on mount

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0e83151 View commit details
    Browse the repository at this point in the history

  5. Ensure correct item is selected upon mount based on the value passed … 

    …to the select
    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    db8379a View commit details
    Browse the repository at this point in the history

  6. Add new test case to make sure initial passed value is selected upon … 

    …mount + fix other tests
    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    751b295 View commit details
    Browse the repository at this point in the history

  7. CSS tweaks

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    d18f88d View commit details
    Browse the repository at this point in the history

  8. More CSS adjustments to make the component behave closer to classic

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    218cc67 View commit details
    Browse the repository at this point in the history

  9. Remove unused prop

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ee619f0 View commit details
    Browse the repository at this point in the history

  10. Fix experimentalHint custom styling on legacy adapter

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ac751d9 View commit details
    Browse the repository at this point in the history

  11. Fix width of popover not always matching the width of the select

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0db8e28 View commit details
    Browse the repository at this point in the history

  12. Improve export name

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    98a0fc4 View commit details
    Browse the repository at this point in the history

  13. Fix label margin not applying in certain contexts

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    e88b0c4 View commit details
    Browse the repository at this point in the history

  14. Add a wrapper around the select as it the main container needs to hav… 

    …e display:block or it might cause visual inconsistencies with other display modes (like flex)
    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    d2cfd1d View commit details
    Browse the repository at this point in the history

  15. Fix withHint handling

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    e47adcf View commit details
    Browse the repository at this point in the history

  16. Fix tests

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    e38a4c8 View commit details
    Browse the repository at this point in the history

  17. Revert accidental change

    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    17f6bbd View commit details
    Browse the repository at this point in the history

  18. Make the select item text non-selectable 

    This was making the l-beam cursor appear when hovering over the items,
which is distracting when you want to just select an item for
the select.
    @fullofcaffeine
    fullofcaffeine committed May 27, 2024
    Configuration menu
    Copy the full SHA
    cd537af View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Merge branch 'trunk' into replace/old-custom-select-control-with-v2-l… 

    …egacy-adapter
    @fullofcaffeine
    fullofcaffeine committed May 28, 2024
    Configuration menu
    Copy the full SHA
    fd5c051 View commit details
    Browse the repository at this point in the history