Site editor: prevent blocking global styles request #61095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +47 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There's a single global styles request that blocks all other loading and requests for the site editor:
The interesting thing is that this data is preloaded, so why is this request made?
Well, it looks like this is requested with
apiFetch, but with theurloption, because this is a url coming from the active theme links.gutenberg/packages/core-data/src/resolvers.js
Lines 543 to 553 in a1b07cd
Unfortunately preload data is designed to only work with the path option, and the root url middleware is loaded after preload data, so it would be a pain to fix preload data for url options.
Upon closer inspection, I noticed that this resource is only fetched to get the global styles ID for the active theme. But we already know this ID from the url, so we shouldn't need to make an additional request.
Why?
Slows down site editor load.
How?
See above
Testing Instructions
Check the network tab for the site editor.
Testing Instructions for Keyboard
Screenshots or screencast