-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: upgrade Ariakit to latest #60992
Conversation
@mirka @tyxla can you help me figure out what I need to look into to make sure this upgrade can safely ship? I don't wanna miss anything. Linking this comment where some of this was already discussed: #60897 (comment) |
What we usually do is:
|
What Lena said. The ariakit changelog is usually pretty thorough. I'd devote special attention to the breaking changes there, although there might be something unintentionally breaking. As we also discussed earlier today, many of our components don't use Ariakit, so the impact of the update won't be as if every component uses Ariakit under the hood. |
Looks like most of the failing tests are due to a change on Also, tooltips no longer assign Other failures appear to prompt |
Thank you very much @diegohaz :) I had parked this PR for a bit to focus on other stuff but your insights are gonna be super helpful as I come back to it (soon). |
hey @DaniGuardiola , do you think you'll be able to resume work on this? It would be good to have the latest version while wrapping up the rewrite of |
@ciampo alright, that's a great reason to bump this in my priority list 👍 |
Moved to main repo, see #62947 |
No description provided.