Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Assess stabilization of BoxControl #60921

Conversation

fullofcaffeine
Copy link
Member

Issue: #59418.

What?

This is part of a larger effort to remove __experimental prefix from all "experimental" components, effectively promoting them to regular stable components. See the related issue for more context.

Why?

The strategy of prefixing exports with __experimental has become deprecated after the introduction of private APIs.

How?

  1. Export it from components without the __experimental prefix;
  2. Keep the old __experimental export for backwards compatibility;
  3. Change all imports of the old __experimental in GB and components to the one without the prefix (including in storybook stories). Also, update the docs to refer to the new unprefixed component;
  4. Add the component storybook id (get it from the storybook URL) to the PREVIOUSLY_EXPERIMENTAL_COMPONENTS const array in manager-head.html so that old experimental story paths are redirected to the new one;
  5. Add a changelog for the change.

@fullofcaffeine fullofcaffeine added [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality labels Apr 19, 2024
@fullofcaffeine fullofcaffeine force-pushed the remove/wp-components-experimental-designation-for-boxcontrol branch from b39700c to 899111b Compare April 19, 2024 18:26
@fullofcaffeine fullofcaffeine marked this pull request as ready for review April 19, 2024 18:31
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: fullofcaffeine <fullofcaffeine@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fullofcaffeine fullofcaffeine self-assigned this Apr 19, 2024
@fullofcaffeine fullofcaffeine requested a review from mirka April 24, 2024 01:05
@fullofcaffeine fullofcaffeine changed the title Components: Remove "experimental" designation for BoxControl Components: Assess stabilization of BoxControl Apr 30, 2024
@fullofcaffeine fullofcaffeine marked this pull request as draft April 30, 2024 09:51
@DaniGuardiola
Copy link
Contributor

Superseded by #65469

@tyxla tyxla deleted the remove/wp-components-experimental-designation-for-boxcontrol branch September 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants