Editor: Support PluginPostStatusInfo Slot in the site editor #60814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Extensibility
youknowriad
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
youknowriad
requested review from
jorgefilipecosta,
ntsekouras and
aaronrobertshaw
|
Size Change: +15 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The description is wrong 😄 - PluginMoreMenuItem -> PluginPostStatusInfo. Do you think we rename the slot to something more close to |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I think it could make sense but If I remember properly we used to consider the whole "summary" as "post status", not the post status property but the status of the post :P My gut feeling say it's not worth it, folks are already using that name and the change is seemless if it's just the package but I also don't feel that strongly. |
ntsekouras
reviewed
Apr 18, 2024
| <PostTemplatePanel /> | ||
| <PostURLPanel /> | ||
| <PostAuthorPanel /> | ||
| <PluginPostStatusInfo.Slot> |
There was a problem hiding this comment.
Is there a specific reason for wrapping these components with the slot? Is it about matching post editor and the concept of grouping this post information together or something else?
There was a problem hiding this comment.
Good question, I did it to match the post editor. I'm guessing there's a small impact on the markup if I don't do it but I'm not sure if it's important.
aaronrobertshaw
approved these changes
Apr 18, 2024
| @@ -93,7 +93,7 @@ const PostStatus = ( { isOpened, onTogglePanel } ) => ( | |||
|
|
|||
| ## Currently available SlotFills and examples | |||
|
|
|||
| The following SlotFills are available in the `edit-post` package. Please refer to the individual items below for usage and example details: | |||
| The following SlotFills are available in the `edit-post` or `editor` packages. Please refer to the individual items below for usage and example details: | |||
There was a problem hiding this comment.
Is there any value in splitting the list below based on package?
There was a problem hiding this comment.
I think not, since they will ultimately be on the same package.
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Similar to #59985
What?
This PR adds support for the
PluginPostStatusInfoto the site editors allowing plugin authors to use the same code to load their plugins regardless of the context of the editor.How?
@wordpress/edit-postto.@wordpress/editorTesting Instructions
You should be able to paste something like the following in both post and site editors (for pages) and have the button show up in the more menu.