Consolidate "bound block" color and "synced" colors #60617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
richtabor
changed the title
|
As an aside, I'm not certain the icon should be added to the toolbar in the first place. This effort is still relevant, regardless of how the UI for expressing a bound block/override changes. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +58 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Apr 10, 2024
| @@ -5,5 +5,4 @@ | |||
| @include admin-scheme(#007cba); | |||
| --wp-block-synced-color: #7a00df; | |||
| --wp-block-synced-color--rgb: #{hex-to-rgb(#7a00df)}; | |||
| --wp-bound-block-color: #9747ff; | |||
There was a problem hiding this comment.
As for changing the colors, I think it's okay, but the base-styles package itself is published as an npm package, and developers may import it. Although this CSS variable was recently added, I don't think it should be removed. Otherwise, if the developer had defined a style like this, the colors would be lost.
@import 'node_modules/@wordpress/base-styles/default-custom-properties';
.element {
color: var(--wp-bound-block-color)
}
There was a problem hiding this comment.
I don't think it should be removed. Otherwise, if the developer had defined a style like this, the colors would be lost.
What wiggleroom is there for errors, which this clearly was? I'd tend to think that with a proper changelog note it should be possible to deprecate this just like other JS pieces can be deprecated.
There was a problem hiding this comment.
My approach is to leave the CSS variable and change it to reference the recommended CSS variable.
:root {
--wp-block-synced-color: #7a00df;
// This CSS variable is not used in Gutenberg project,
// but is maintained for backwards compatibility.
--wp-bound-block-color: var(--wp-block-synced-color);
}
jasmussen
approved these changes
Apr 10, 2024
|
I've researched this comment, and indeed the old CSS variable needs to be updated. Otherwise, the outline will not be visible when any source is bound to the block. trunk:
This PR:
By entering the following HTML in the code editor, you can test the block to which the source is bound. <!-- wp:paragraph {
"metadata":{
"bindings":{
"content":{
"source":"core/post-meta",
"args":{
"key":"book-genre"
}
}
}
}
} -->
<p></p>
<!-- /wp:paragraph --> |
Added in 9e89ece. |
jameskoster
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A piece of #60286.
Consolidate
--wp-bound-block-colorand--wp-block-synced-colorinto one variable. They're just slightly different purples, where it's not really necessary. Synced patterns use--wp-block-synced-coloralready, perhaps bindings should just use that too. #60599 leans into--wp-block-synced-colorfor overrides as well.Testing Instructions
Screenshots or screencast