-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor styles: relocate .editor-styles-wrapper class to the HTML element #60398
Conversation
… the HTML element in the block editor. Doing this effectively reduces specificity of backwards compatibility rules using :where() so they do not override any theme rules in :root. Rollback
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a fair bit of backwards compat testing, but seems to work on the surface.
@@ -11,7 +11,7 @@ | |||
// Themes with theme.json can control this themselves. | |||
// For full-wide blocks, we compensate for the base padding. | |||
// These margins should match the padding value above. | |||
html :where(.editor-styles-wrapper) { | |||
:where(html.editor-styles-wrapper) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test according to original issue:
@@ -58,7 +58,7 @@ | |||
|
|||
@import "./editor-elements.scss"; | |||
|
|||
:root .editor-styles-wrapper { | |||
:where(html.editor-styles-wrapper) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test according to original PR:
* When the post editor is fully i-framed, this extra classname could be removed. | ||
* Note: in the block editor, `.editor-styles-wrapper` is added to the HTML element | ||
* in the `IFrame` component, packages/block-editor/src/components/iframe/index.js. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just formatting mainly. Added note about location of classname
@@ -150,7 +150,9 @@ function Iframe( { | |||
); | |||
iFrameDocument = contentDocument; | |||
|
|||
documentElement.classList.add( 'block-editor-iframe__html' ); | |||
documentElement.classList.add( | |||
'block-editor-iframe__html editor-styles-wrapper' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main thrust of this PR occurs here
Size Change: +10 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
Closing this one as it causes more problems than it fixes. |
Warning
This PR is just an exploration. A lot of the code depends on the .editor-styles-wrapper class being on the body tag, so it's probably not viable.
What and how? And why?
Exploring solutions to:
This is a test to move the reduce the .editor-styles-wrapper class to the HTML element in the block editor.
Doing this effectively reduces specificity of backwards compatibility rules using :where() so they do not override any theme rules in :root.
Testing Instructions