-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates: fix deferred rendering #60361
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +7 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it would be better to update view.hiddenFields
based on the existence of special layout fields (ex. mediaField), but since these fields and their handling might change, I think it's good to land for now. Thanks!
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Part of #55083
Extracted from #60069
What?
The deferred rendering mechanism is used in templates when the
preview
field is visible. This renders template items in batches of 3. However, we've missed that the preview is always visible in the grid layout.This PR activates deferred loading when the grid layout is in use as well:
Gravacao.do.ecra.2024-04-02.as.12.45.07.mov
How?
deferredRendering
should be active when the preview field is present or the grid layout is in use (that contains previews). d593443Testing Instructions
Visit the Templates page and switch to the grid layout. Verify items load in batches of 3.