-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Bindings: set allow blocks list from source handler #60335
base: trunk
Are you sure you want to change the base?
Block Bindings: set allow blocks list from source handler #60335
Conversation
Size Change: +157 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1cec195
to
3278a35
Compare
There is now an issue open by @zaguiini that describes how the block types and their attributes will get annotated on the block registration level: In the same area, @fabiankaegy described how we could allow using block bindings with dynamic blocks: @retrofox, do you plan to continue working on this PR? |
Yes, I do. I'm not sure whether it's doable in the short time, though. |
What?
This PR allows defining the block attributes that can be bound from the source handler instead of a hardcoded list.
Why?
It allows for binding an attribute of a custom block, for instance.
How?
For this purpose, the PR introduces the
settings
property to the source handler, which makes it possible to define the block attributes allowed to bind. For instance, for the core/post-meta source handler:Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast