Make sure the CSS class is-dark-theme is added to the editor iframe body #60300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +42 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…ody. (WordPress#60300) Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
|
This change breaks the iframe setup in Safari, so I think we need to revert this and look for a different approach to maintain the dark theme class. I will take a look and see what can be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60299
Cc @youknowriad @ellatrix
When you have a chance, I'd appreciate a review, as this is a blocker for another issue I'm working on.
For more details, please see the associated issue.
What?
When a theme has a dark background, the editor is supposed to set a CSS class
is-dark-themeto the editor iframe document body. This works in the Site editor, It doesn't in the Post editor.The editor
Iframecomponent has some internal logic to get some of the CSS classes set on the main document body like for examplepost-type-post admin-color-fresh wp-embed-responsiveand then copy them to the iframe document body.That makes sense but by doing so it replaces the
is-dark-themeclass, if it is set. Actually, I think the wholebodyis replaced? Regardless, theis-dark-themeclass is missing.This happens only in the Post editor. In the Site editor, the CSS class is present so that I'm guessing it's also something related to timing.
Why?
The
is-dark-themeCSS class is necessary for some styling in the editor. The lack of this CSS class is also a blocker for #60275How?
Iframecomponent handling of the CSS classes also gets the classes that are initially set on the iframe body.Testing Instructions
is-dark-themeis not set in the post editor #60299block-editor-iframe__body editor-styles-wrapper.is-dark-theme.block-editor-iframe__body editor-styles-wrapper.is-dark-theme.is-dark-themestays there also when the iframe is fully loaded.Testing Instructions for Keyboard
Screenshots or screencast