Blocks: Fix double gutenberg_ prefix in built dynamic blocks PHP
#60288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Bug
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…dPress#60288) Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: adamziel <zieladam@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
During the build step of the block-library package, function names found in dynamic blocks' PHP code are prefixed with
gutenberg_(to avoid collisions with their unprefixed counterparts in Core).If a function name is fully included in another function's name -- e.g.
block_core_navigation_insert_hooked_blocksandblock_core_navigation_insert_hooked_blocks_into_rest_response-- the latter is prefixed twice, due to the way the function name is searched for. In the example above, this results in the function being named ingutenberg_gutenberg_block_core_navigation_insert_hooked_blocks_into_rest_responseinbuild/block-library/blocks/navigation.php.This PR fixes this problem.
Why?
To fix #40938.
How?
By making sure a function call is only replaced if the matched string isn't part of a longer function name.
Testing Instructions
rm -rf build && npm run buildbuild/block-library/blocks/navigation.php.gutenberg_block_core_navigation_insert_hooked_blocks_into_rest_response.