TextControl: Apply zero margin to input element #60282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
changed the title
margin: 0
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -45 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Mar 28, 2024
There was a problem hiding this comment.
I generally agree with the change, but wasn't able to see it in effect.
That's likely because we're adding it to the number fields only, and that doesn't affect all the non-number text fields.
I also wonder if this can have any unforeseen consequences. Might require a broader testing of all places that render text control inputs.
From searching the code, it appears that there is no effect. Search Search |
tyxla
approved these changes
Mar 29, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* TextControl: Apply `margin: 0` * Update changelog * Add comment Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59761
What?
This PR applies
margin:0to theinputelement inside theTextcontrolcomponent.Why?
As the screenshot in #59761 shows, WP Core applies a 1px margin on both sides of the
inputandselectelements as a form style. This may make sense on the dashboard, but on aTextControlcomponent it's an unintended style and causes a 1px misalignment.How?
Applies
margin: 0to theinputelement inside theTextControlcomponent.As another approach, I considered applying the margin to the
input-controlmixin itself, but I rejected it for the following reasons:base-stylespackage themselves, and it may affect their UI.TextControlcomponent that is causing this problem. For example, in other components we override the left and right margins with zero as below:gutenberg/packages/components/src/select-control/styles/select-control-styles.ts
Line 132 in 6ebbb8b
gutenberg/packages/components/src/input-control/styles/input-control-styles.tsx
Line 219 in 6ebbb8b
gutenberg/packages/components/src/radio-control/style.scss
Line 10 in 6ebbb8b
Testing Instructions
Screenshots or screencast
Below is an example of a block sidebar.
Before
The 1px margin pushes the component to the right and doesn't line up with other components.
After
It should line up perfectly with the other components.