CustomSelectControlV2: Fix hint behavior in legacy #60183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Mar 26, 2024
mirka
force-pushed
the
fix/custom-select-hint
branch
from
da622b8 to
414011d
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Add tests (failing) * CustomSelectControlV2: Fix hint behavior in legacy * Add changelog Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* Add tests (failing) * CustomSelectControlV2: Fix hint behavior in legacy * Add changelog Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55023
Stacked on #60182
What?
Fixes an incorrect back compat implementation in CustomSelectControlV2 Legacy where "hints" in the dropdown should always be shown if available, regardless of the
__experimentalShowSelectedHintprop.Why?
The CustomSelectControlV2 Legacy implementation needs to match the v1 behavior as close as possible.
How?
By adding a new unit test to v1, I established that hints in the dropdown options are always shown if provided, regardless of whether the
__experimentalShowSelectedHintprop is enabled. (As the prop name accurately describes, the boolean is supposed to only control the visibility of the hint in the selected option — the one shown in the dropdown trigger.)I then fixed the unit test in v2 Legacy to reflect this correct spec.
Finally, I fixed the v2 Legacy implementation so the failing test passes.
Testing Instructions
This behavior can also be confirmed in the Storybook stories for CustomSelectControl V2 Legacy "With Hints" and CustomSelectControl "With Hints", by toggling the
__experimentalShowSelectedHintprop control.