Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Variable name correction in the documentation #60056

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

steveariss
Copy link
Contributor

What?

Minor correction to a variable name referenced in a code snippet on the interactivity api documentation

Why?

The current code snippet in the documentation is incorrect. wp_interactivity_process_directives() is being passed an undefined value

How?

Testing Instructions

N/A

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2024-03-20 at 5 06 24 PM

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @steveariss.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: steveariss.


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 20, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @steveariss! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Copy link
Contributor

@DAreRodz DAreRodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you @steveariss. 🙏

@DAreRodz DAreRodz added [Type] Developer Documentation Documentation for developers [Feature] Interactivity API API to add frontend interactivity to blocks. [Packages] Interactivity /packages/interactivity labels Mar 22, 2024
@DAreRodz DAreRodz changed the title Variable name correction in the interactivity api documentation Interactivity API: Variable name correction in the documentation Mar 22, 2024
@DAreRodz DAreRodz merged commit aa4c608 into WordPress:trunk Mar 22, 2024
60 of 64 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.1 milestone Mar 22, 2024
@steveariss steveariss deleted the patch-1 branch March 22, 2024 14:10
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Interactivity API API to add frontend interactivity to blocks. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Packages] Interactivity /packages/interactivity [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants