-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensibility: Support PluginBlockSettingsMenuItem in the site editor #60033
Conversation
@@ -41,61 +41,7 @@ _Parameters_ | |||
|
|||
### PluginBlockSettingsMenuItem | |||
|
|||
Renders a new item in the block settings menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunate that we don't have the automatic documentation in the editor package's README too but it should be considered separately from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that, too. It's probably related to the configuration.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +3 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
b0f6ad8
to
a3b5025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is for the block toolbar, so it is general enough, and it might even be considered as a bug fix now that post and site editors have been unified.
…WordPress#60033) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
Related #52632
Similar to #59985
What?
This PR makes the
PluginBlockSettingsMenuItem
available in the site editor, just like the post editor.How?
@wordpress/edit-post
to.@wordpress/editor
Testing Instructions
You should be able to paste something like the following in both post and site editors and have the panel show up in the sidebar of pages.