Update the query block to permit non-core interactive blocks

[colinduwe]

What?

Allow non-core interactive blocks to be placed inside the core/query block

Fixes #59752

Why?

With the introduction of the interactivity API, extenders are eager to use the API with the core/query block to enhance WordPress sites. This adjustment allows them to be used.

How?

Adds a check to ensure that any non-core blocks inside the core/query block have their block.supports.interactivity property set to true.

Testing Instructions

1. Create a new page/post with query with a post template and pagination within it.
2. Set the query's "Force page reload" to false
3. Add a non-core block inside the query.
4. Verify that you get the modal alerting you that non-interactive plugin blocks are not allowed. "Force page reload" is enabled.
5. Add a non-core block that has block.supports.interactivity inside the query
6. Verify you can enable/disable the "Force page reload"
7. On the front end verify that the advanced pagination works as expected.

Here's a non-core block with block.supports.interactivity you can use to test this: test static block

Query.Allow.Plugin.Blocks.mov

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @poof86.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: poof86.

Co-authored-by: colinduwe <colind@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: sethrubenstein <smrubenstein@git.wordpress.org>
Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[cbravobernal]

We can include as well non interactive blocks that supports client navigation (disabling force page reload). Those ones should have this block supports structure. You can check the paragraph block for example.

	"interactivity": {
			"clientNavigation": true
		}

[cbravobernal]

Thanks for working on this PR!
I think we can adapt it to be compatible with every block that indicates the interactivity support.

[colinduwe]

The PR does work with both ways blocks currently indicate interactivity support

I did just test and if you were to make a block with this:
"interactivity": {
"clientNavigation": false
}
evaluates as true and allows you to add it to a query block. I will fix up the check.

But as I think about it, maybe we only want this to check clientNavigation since that's the interaction at issue in the query block rather than other interactions.

[cbravobernal]

Thanks for the PR.
Just those small nitpicks and is ready to go.

Tested and works fine! It would be awesome if we can add a test.

[cbravobernal]

Can we rename this to a more descriptive name? Something like blockSupportsInteractivityClientNavigation

[cbravobernal]

I've set the label as a bug instead of an enhancement. As in PHP, it's already checking the block supports. In the editor part, it should have done the same thing in WP 6.5

I hope we can land this in 6.5.1

[colinduwe]

I'd love to understand how to write a test for this but can't make heads or tails of the sprawling documentation. It seems like it should just be a unit test of useUnsupportedBlocks() in the utils file. Can anyone suggest a tutorial or another block to look to as template?

[cbravobernal]

I'd love to understand how to write a test for this but can't make heads or tails of the sprawling documentation. It seems like it should just be a unit test of useUnsupportedBlocks() in the utils file. Can anyone suggest a tutorial or another block to look to as template?

An option could be to make an e2e like the one in test/e2e/specs/editor/blocks/query.spec.js or something similar than https://github.com/WordPress/gutenberg/blob/6ba2c4e8d938ddf6905ec5f0ee911f5b7726a397/test/e2e/specs/editor/various

I'll leave the PR approved, so you can add the test in a follow-up PR.

[cbravobernal]

Suggested change

	const blockSupportsInteractivityBool = Object.is(
	const blockSupportsInteractivity = Object.is(

[tellthemachines]

I just cherry-picked this PR to the add/fixes-for-651 branch to get it included in the next release: 79babed