-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Editor Header: Make block toolbar toggle button focus visible #59781
Conversation
Size Change: +27 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't deeply test this at the moment, have to finish some other things, but the code alone looks good. Thanks for the PR.
Sorry, I forgot to merge this PR 😅 I have imported the latest trunk into this PR, but it has been fixed as expected, so I would like to merge it. |
…ordPress#59781) * Post Editor Header: Make block toolbar toggle button focus visible * Use CSS variable Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Part of #58293
What?
This PR fixes an issue where the focus of the block tool toggle button is hidden when the fixed toolbar is enabled in the post editor.
Before
After
Why?
Because the header toolbar has
overflow: hidden
applied for horizontal scrolling.How?
Add 2px padding to the right side of the header toolbar. This approach is already applied in the Site Editor:gutenberg/packages/edit-site/src/components/header-edit-mode/style.scss
Lines 27 to 30 in fdf8fa6
Update: I used the
--wp-admin-border-width-focus
variable in both the Site Editor and the Post Editor. This variable will have the appropriate value depending on the screen resolution.Testing Instructions