-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichText: document disableEditing
property
#59755
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Isn't this an internal thing? Why not reuse the contentEditable prop instead? |
Yes, it's an external thing so far. That's why I moved the PR to draft. |
It would be nice to stick to normal HTML attributes like |
Sorry, I probably didn't make it clear in the discussion, rather than just documenting it we would need to go through the process of taking this out of the experimental APIs first as we don't document experimental APIs. We should look into Ella's concerns though before doing that.
From memory, there was some reason why these attributes did not work in the context of the pattern overrides. I can't remember exactly what the problem was, but will have another look during the week and see if I can recall what the issues were. |
This was the reason we didn't use |
@ellatrix looks like switching this to What are your thoughts on this, and on the possibility of making this part of the public API? Happy to switch it to |
That's fine |
What?
It documents the RichText
disableEditing
propertyWhy?
Improve documentation
How?
Just editing the Readme file.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast