Cover Block: Restore overflow: clip rule to allow border radius again #59388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
andrewserong
requested review from
noisysocks,
jameskoster,
jasmussen,
richtabor,
ramonjd and
tellthemachines
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewserong
added
the
Browser Issues
|
Size Change: +7 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Feb 27, 2024
tellthemachines
approved these changes
Feb 27, 2024
|
Thanks for the reviews, folks! I'll merge this in as it resolves the regression. If there are any objections about the change in terms of the aspect ratio block support, we can look into it as a bug (or room for enhancement) with that block support 👍 |
andrewserong
added
Backport to WP 6.7 Beta/RC
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
…#59388) * Cover Block: Restore overflow: clip rule to allow border radius again * Fully restore to prior to aspect ratio PR Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: luminuu <luminuu@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: d9a49b4 |
getdave
added
Backported to WP Core
|
Thanks for the speedy fix for this one! |
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
…#59388) * Cover Block: Restore overflow: clip rule to allow border radius again * Fully restore to prior to aspect ratio PR Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: luminuu <luminuu@git.wordpress.org>
creativecoder
pushed a commit
that referenced
this pull request
Feb 27, 2024
…#59388) * Cover Block: Restore overflow: clip rule to allow border radius again * Fully restore to prior to aspect ratio PR Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: luminuu <luminuu@git.wordpress.org>
|
I just cherry-picked this PR to the release/17.8 branch to get it included in the next release: a4156a0 |
creativecoder
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #59366
Fix border radius for the Cover block by restoring the previous
overflow: clipCSS rule.Why?
When the aspect ratio block support was introduced in #56897, it turns out the behaviour depended on a bug in Chrome that (incorrectly) allowed
overflow-x: clipto apply rounded edges to a clipping region while still allowing the content area to expand vertically. As of Chrome122.xthat bug has been resolved, which means thatoverflow-x: clipnow results in border radius not clipping the image for the Cover block as it's expected to.This fix proposes restoring the
overflow: cliprule for 6.5 to fix the border radius issue. The downside of doing this is that on smaller viewports, the content area of the block with an aspect ratio will not expand beyond its aspect ratio proportions. However, since aspect ratio is a new feature in 6.5, I believe it's preferable for us to restore behaviour that preserves border-radius for now.We could potentially look at further follow-ups to the aspect ratio support in 6.6.
How?
Restore
overflow: cliprule in the Cover block.Testing Instructions
122.x)Testing Instructions for Keyboard
Screenshots or screencast