Fix: Rerender toolbar when parent block changes #59234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeryj
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +21 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Feb 21, 2024
| @@ -97,6 +98,7 @@ export function PrivateBlockToolbar( { | |||
|
|
|||
| shouldShowVisualToolbar: isValid && isVisual, | |||
| rootClientId: blockRootClientId, | |||
| toolbarKey: `${ selectedBlockClientId }${ firstParentClientId }`, | |||
There was a problem hiding this comment.
Why add a new selected key here? Can't we concatenate on render?
There was a problem hiding this comment.
We need access to the firstParentClientId outside of the selector, so we'll need to add a selected key of either the firstParentClientId or the concatenated toolbarKey. I can see how firstParentClientId would be more potentially useful than a toolbarKey.
ellatrix
approved these changes
Feb 21, 2024
draganescu
force-pushed
the
fix/parent-change-block-toolbar-rerender
branch
from
0541076 to
39cc2ff
Compare
andrewserong
added
the
Backport to Gutenberg RC
|
I just cherry-picked this PR to the release/17.9 branch to get it included in the next release: ab09164 |
andrewserong
pushed a commit
that referenced
this pull request
Mar 12, 2024
…#59234) Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
andrewserong
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When outdenting an individual list item from a sub-item to a top-level item, the all of the items in the toolbar loses a focusable item with a tabindex of 0. Updating the key to include the first parent item (if present) allows the toolbar to know to rerender and reset to have a focusable button within it.
Testing Instructions