Update document title position so that it's centrally aligned #59078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +41 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 19f6b5b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7917191394
|
t-hamano
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Thanks for the PR!
I think the tricky part about this issue is that the header buttons on the right side can be extended by plugins.
For example, if you run the code below in the browser console, overlapping will occur depending on the width of the browser.
for (let i = 0; i < 4; i++) {
wp.plugins.registerPlugin( 'my-plugin-sidebar-' + i, {
render: function () {
return React.createElement(
wp.editSite.PluginSidebar,
{
name: 'my-plugin-sidebar-' + i,
icon: 'admin-post',
}
);
},
} );
}724d6bb630990745f6ca65c57779409a.mp4
In reality, such cases are unlikely, but I think edge cases like this need to be considered as well.
One of my ideas is to put the header row in a grid layout without changing the document title to absolute alignment.
.edit-site-header-edit-mode {
display: grid;
grid-template-columns: 1fr 1fr 1fr;
}However, simply using this approach may result in unintended layout disruptions.
Or perhaps we could dynamically calculate the left and right margins of the header row to make the document title bar's width variable.
@draganescu As I recall, you were working on dynamically calculating the width of the header toolbar. Have any ideas?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Sirjazzfeetz. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The grid approach could work in theory, so long as we offset the title by |
|
I recently explored this as well in #59134; was finally annoyed enough by it. I went the flex route. |
|
@richtabor that seems to work well! |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
|
Closing this. Rich's approach works better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29673.
What?
Align the document title centrally in the viewport.
Why?
See #29673.
How?
On large viewports (
xlargebreakpoint) absolutely position the container then offset usingtransform.Testing Instructions
Screenshots
Top is trunk, bottom is this PR. The red line represents the center point.