Shadows: Don't assume that core provides default shadows #58973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
commented
Feb 13, 2024
|
This pull request changed or added PHP files in previous commits, but none have been detected in the latest commit. Thank you! ❤️ |
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
vcanales
force-pushed
the
fix/default-shadows-missing
branch
from
476e9bf to
2907e81
Compare
vcanales
approved these changes
Feb 13, 2024
|
Flaky tests detected in 2907e81. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7891311378
|
madhusudhand
added
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: vcanales <vcanales@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org>
|
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 0ef370b |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added
the
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: vcanales <vcanales@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Handle the case where core doesn't provide a default shadow.
Why?
When I was testing #58951 I discovered that removing the shadows from the core theme.json throws a javascript error.
How?
Set defaultShadows to an empty array if it's undefined.
Testing Instructions