Allow rich text formatting across blocks #58913
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Feature] Rich Text
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @crgeary. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +604 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a00569d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7861117849
|
|
There are some edge cases that need to be sorted out. When I create a Site Title block and select it together with a paragraph: 
What should happen when I click the Bold button? Currently it will crash, calling The The Site Title's RichText also specifies Similar issues arise when I select a List followed by a Paragraph: 
Here the List Items are not even part of the selection, |
|
I know there's still quite a few things to figure out, this PR is not ready yet. Should've maybe put it into draft status. |
Turns out that this is a default I'm wondering what kind of backward compatibility does this provide and whether we could get rid of this default value. The Here's one example where this backfires. Select parts of two adjacent blocks, Site Title and Paragraph: 
First, the UI shows both blocks as fully selected, but the selection is partial: see the Second, if you now hit Enter, the |
ellatrix
commented
May 22, 2024
| shortcut: 'i', | ||
| icon: formatItalic, | ||
| title: __( 'Italic' ), | ||
| }, |
There was a problem hiding this comment.
At some point I'd like to refactor rich text format registration to work without edit functions, much like how we'd envision a Block API (and data view fields) without edit functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows you to bold etc. after selecting across multiple blocks.
Why?
Fixes #27221.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast