Commands: Try debouncing search for post-type navigation #58810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
requested review from
youknowriad,
ntsekouras,
t-hamano and
richtabor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Feb 8, 2024
| @@ -33,17 +34,35 @@ const icons = { | |||
| wp_template_part: symbolFilled, | |||
| }; | |||
|
|
|||
| function useDebouncedValue( value ) { | |||
| const [ debouncedValue, setDebouncedValue ] = useState( '' ); | |||
| const debounced = useDebounce( setDebouncedValue, 400 ); | |||
There was a problem hiding this comment.
Happy to adjust the delay.
|
Size Change: +63 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 33b000a7ab82b50e20034785a74f044cd6986635. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7827458336
|
|
Feels like we should use a similar delay on all of these useDebounceInput calls. Looks like the hardcoded value there is 250ms |
|
I am not sure; 400ms might be a bit long for the inserter. I guess it all depends on what we're debouncing. |
|
I was thinking the opposite, update this PR to use 250? |
|
That makes more sense 😅 |
youknowriad
approved these changes
Feb 8, 2024
Mamaduka
force-pushed
the
try/debounce-post-type-seach-command
branch
from
773a5ac to
ebf96f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR tries to debounce search requests made by post-type navigation commands.
Why?
Currently, the command is making a request for each keystroke, which can be expensive depending on the WP installation size.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2024-02-08.at.13.14.16.mp4