Tweak revisions panel for improved scanning #58751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +613 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Feb 7, 2024
|
Looks good! |
|
Nice change. I wonder if it's worth putting the count in a pill, e.g.: 
Something about the heavy parenthesis looks a little clunky. |
Yea, I was thinking that too perhaps. |
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
|
I think it's okay to merge this PR, but what do you think about removing the parentheses if they bother you? Instead, display
|
I'd like to follow-up with what @jameskoster proposed. I think that'd work better across the board, where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks the Revisions PanelBody to be more aligned with the other items. All other PanelBody items have text aligned left and the relative icon on the right, and the site editor revisions also use this notion of "Revisions (X)".
Testing Instructions
Screenshots or screencast