-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library: Synchronize code with Gutenberg 17.6 #58671
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/fonts/class-wp-font-collection.php ❔ lib/compat/wordpress-6.5/fonts/class-wp-font-library.php ❔ lib/compat/wordpress-6.5/fonts/class-wp-font-utils.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/getData.php ❔ phpunit/tests/fonts/font-library/wpFontUtils/sanitizeFromSchema.php ❔ lib/load.php ❔ phpunit/tests/fonts/font-library/fontFamilyBackwardsCompatibility.php ❔ phpunit/tests/fonts/font-library/fontLibraryHooks.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/__construct.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/base.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollections.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/registerFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/unregisterFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontUtils/getFontFaceSlug.php ❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController.php ❔ phpunit/tests/fonts/font-library/wpRestFontFacesController.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController.php ❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-collections-controller.php ❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-faces-controller.php ❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-families-controller.php ❔ lib/compat/wordpress-6.5/fonts/fonts.php ❔ lib/experimental/font-face/bc-layer/class-gutenberg-fonts-api-bc-layer.php ❔ lib/experimental/font-face/bc-layer/class-wp-fonts-provider-local.php ❔ lib/experimental/font-face/bc-layer/class-wp-fonts-provider.php ❔ lib/experimental/font-face/bc-layer/class-wp-fonts-resolver.php ❔ lib/experimental/font-face/bc-layer/class-wp-fonts-utils.php ❔ lib/experimental/font-face/bc-layer/class-wp-fonts.php ❔ lib/experimental/font-face/bc-layer/class-wp-web-fonts.php ❔ lib/experimental/font-face/bc-layer/class-wp-webfonts-provider-local.php ❔ lib/experimental/font-face/bc-layer/class-wp-webfonts-provider.php ❔ lib/experimental/font-face/bc-layer/class-wp-webfonts-utils.php ❔ lib/experimental/font-face/bc-layer/class-wp-webfonts.php ❔ lib/experimental/font-face/bc-layer/webfonts-deprecations.php ❔ phpunit/tests/fonts/font-library/wpFontUtils/sanitizeFontFamily.php ❔ phpunit/tests/fonts/font-library/wpFontsDir.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the Gutenberg version of this PR with:
✔️ WordPress core running this branch: WordPress/wordpress-develop#6027
✔️ WordPress core 6.4
The font library continue working as expected on both cases.
LGTM
This PR backports all the Font library code from trunk into 17.6 to perform a patch release of Gutenberg.
The reason is that the Core backport of the font library code is blocked because the latest Gutenberg release conflicts with that Core backport.
In order to avoid breaking production sites using core trunk, we need to perform a patch release of Gutenberg first with these changes.