DocumentBar: Simplify component, use framer for animation #58656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -114 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I like all the proposed changes here. Thanks for this work Robert :) |
|
I believe the back buttons have been unified on trunk though, so this probably needs refreshing. |
noisysocks
force-pushed
the
update/use-framer-in-document-bar
branch
from
3e98761 to
0de3c9e
Compare
|
Trunk 2024-02-20.13.15.50.mp4This PR 2024-02-20.13.12.45.mp4 |
|
Thanks for the review 🙂 it pleases me to get rid of that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why
Simplifies the
DocumentBarthe component.I split these changes out of #58528.
DocumentBarandBaseDocumentActions. Having the component split up like this made sense back when we would conditionally return a different "base" component depending on the rendering mode. We don't do that now, though, so it just adds unnecessarily complexity.useSelect()anduseEntityRecordhooks into a singleuseSelect. This is simpler and ought to result in less updates.is-animatedCSS class which is added on mount. I originally used framer when implementing the animation in DocumentActions: Animate between page and template mode #51224 but had to get rid of it because we were rendering different base components depending on the mode (see above). We no longer do that.Testing Instructions