Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Library: Rename variation build methods #58538

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Block Library: Rename variation build methods #58538

merged 1 commit into from
Feb 1, 2024

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Feb 1, 2024

What?

This is a follow-up to #56952 (comment).

PR renames new variation build methods to follow coding standards.

Testing Instructions

  1. Open a post or page.
  2. Ron following snippets in DevTools Console - wp.blocks.getBlockType('core/post-terms') and wp.blocks.getBlockType('core/navigation-link')
  3. Ensure that the block object returned has variations.

Testing Instructions for Keyboard

Same.

@Mamaduka Mamaduka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Block library /packages/block-library labels Feb 1, 2024
@Mamaduka Mamaduka self-assigned this Feb 1, 2024
@Mamaduka Mamaduka mentioned this pull request Feb 1, 2024
Merged
anton-vlasenko
anton-vlasenko approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@anton-vlasenko anton-vlasenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this pull request!
It's important to adhere to the existing coding standards, and your PR contributes to that.
I've tested the changes, and everything is working as expected. Great job!

Snímek obrazovky 2024-02-01 v 13 29 35

@Mamaduka
Copy link
Member Author

Mamaduka commented Feb 1, 2024

Thanks for the review, @anton-vlasenko!

@Mamaduka Mamaduka merged commit 180ae59 into trunk Feb 1, 2024
61 checks passed
@Mamaduka Mamaduka deleted the update/variation-callback-names branch February 1, 2024 13:09
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-vlasenko anton-vlasenko anton-vlasenko approved these changes

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@Mamaduka Mamaduka

Labels
[Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 17.7
Development

Successfully merging this pull request may close these issues.
2 participants
@Mamaduka @anton-vlasenko