Interactivity Router: Fix initial page cache #58496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
|
Size Change: +199 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e82e7c5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7725587601
|
luisherranz
reviewed
Jan 31, 2024
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
DAreRodz
force-pushed
the
fix/interactivity-router-initial-page-cache
branch
from
5f67027 to
f03e339
Compare
DAreRodz
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Epic: #56803
This PR ensures the first page is cached using the vDOM tree generated during hydration.
Why?
As the
@wordpress/interactivity-routermodule is loaded asynchronously, it currently caches the first page traversing the current DOM, which interactive blocks could have modified. This PR prevents that issue by using the same vDOM hydrated.How?
Exposing from the
@wordpress/interactivitymodule aWeakMapcalledinitialVdom, relating the generated vDOM trees with the root node where they are hydrated. ThisinitialVdomweak map is exposed from a function namedprivate APIs, which also returns other APIs meant to only be used internally.Testing Instructions