Fix: refactor pre publish panel to use function component instead of class #58441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
added
[Type] Code Quality
|
Size Change: -139 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Jan 30, 2024
|
Flaky tests detected in 16b7fbf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7727325230
|
|
@fabiankaegy, we can drop P.S. We should also avoid using the global |
|
@fabiankaegy, do you mind if I push small changes on this branch? Mostly some personal nits :) |
|
@Mamaduka not at all :) you are always welcome to take over any branch I'm working on 👍 |
Mamaduka
reviewed
Jan 31, 2024
Comment on lines
+48
to
+49
| hasTags: !! tags?.length, | ||
| isPostTypeSupported: areTagsFetched && _isPostTypeSupported, |
There was a problem hiding this comment.
- it is preferable to derive values like
hasTagsinsidemapSelec. It will prevent re-rendering components when a new tag is assigned to a post. - I have combined post-type support check since if tags taxonomy has not been fetched yet, the
_isPostTypeSupportedvalue will always befalse
Mamaduka
approved these changes
Jan 31, 2024
fabiankaegy
deleted the
fix/refactor-pre-publish-tags-to-use-function-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor pre publish panel to use function component instead of class
Why?
For easier maintainance going forward
How?
Replace component constructor with hook based state
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast