Widget Editor: Don't disable the Save button #58365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: -4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
t-hamano
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
Mamaduka
reviewed
Jan 29, 2024
| @@ -26,9 +26,8 @@ function SaveButton() { | |||
| <Button | |||
| variant="primary" | |||
| isBusy={ isSaving } | |||
| aria-disabled={ isSaving } | |||
| aria-disabled={ isSaving || ! hasEditedWidgetAreaIds } | |||
| onClick={ isSaving ? undefined : saveEditedWidgetAreas } | |||
There was a problem hiding this comment.
I think the condition here also needs to be updated. A user should not be able to click on the button when ! hasEditedWidgetAreaIds.
PS. We should probably define isDisabled condition.
There was a problem hiding this comment.
Thanks for the review! I updated via 16282ad, does this make sense?
|
@Mamaduka @draganescu Thanks for the review! It seems that React Native E2E Tests are also failing on trunk, so I would like to update and merge this PR after that issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #42842
What?
PR removes the
disabledattribute from the Widget Editor's save button component.Why?
#42802 about the Site editor explains why having both disabled and aria-disabled is a problem.
How?
Moved the variable that defines whether the
disabledattribute is enabled to thearia-disabledattribute and removed thedisabledattribute.Testing Instructions
disabledattribute andaria-disabledshould betrue.disabledattribute andaria-disabledshould befalse.disabledattribute andaria-disabledshould betrue.Screenshots or screencast
26a145cabff808e2e5dc2abc706f09dd.mp4