InnerBlocks: fix continuous re-rendering on inner blocks change #58348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -25 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in deb0e11. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7678293373
|
ellatrix
commented
Jan 27, 2024
| @@ -112,5 +110,5 @@ export default function useInnerBlockTemplateSync( | |||
| return () => { | |||
| isCancelled = true; | |||
| }; | |||
| }, [ innerBlocks, template, templateLock, clientId ] ); | |||
| }, [ template, templateLock, clientId ] ); | |||
There was a problem hiding this comment.
Note the condition on this line:
Nothing happens unless the template changed.
youknowriad
approved these changes
Jan 27, 2024
|
Really strange that there's no improvement in the last run, let's see code vitals I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently when typing in a list (or any block using inner block such as group, quote, etc.) the whole list re-renders. This is because all inner blocks hooks are subscribed to their inner blocks.
Subscribing to inner blocks doesn't seem to be needed because
useInnerBlockTemplateSyncdoes nothing unless the template changes.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast