Block Editor: Optimize the 'useBlockDisplayTitle' hook #58250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
Size Change: -3 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Jan 25, 2024
| const attributes = getBlockAttributes( clientId ); | ||
| const isReusable = isReusableBlock( blockType ); | ||
| const reusableBlockTitle = isReusable | ||
| ? __experimentalGetReusableBlockTitle( attributes.ref ) |
There was a problem hiding this comment.
We should probably deprecate this selector and handle the pattern block title via __experimentalLabel.
cc @talldan, @kevin940726
There was a problem hiding this comment.
Note that I'm adjusting this selector here Avoid fetching ALL reusable blocks (user patterns) on post/site editor load
There was a problem hiding this comment.
Here's the correct PR link - #58239.
ellatrix
reviewed
Jan 25, 2024
| ); | ||
|
|
||
| const blockInformation = useBlockDisplayInformation( clientId ); |
There was a problem hiding this comment.
In the sense that you might be getting a bunch of info that you don't need
ellatrix
approved these changes
Jan 25, 2024
|
Thanks for the review, @ellatrix! |
westonruter
added a commit
that referenced
this pull request
Jan 26, 2024
…zy-hydration * origin/trunk: (47 commits) Interactivity API: Break up long hydration task in interactivity init (#58227) Add supports.interactivity to Query block (#58316) Font Library: Make notices more consistent (#58180) Fix Global styles text settings bleeding into placeholder component (#58303) Fix the position and size of the Options menu, (#57515) DataViews: Fix safari grid row height issue (#58302) Try a fix (#58282) Navigation Submenu Block: Make block name affect list view (#58296) Apply custom scroll style to fixed header block toolbar (#57444) Add support for transform and letter spacing controls in Global Styles > Typography > Elements (#58142) DataViews: Fix table view cell wrapper and BlockPreviews (#58062) Workflows: Add 'Technical Prototype' to the type-related labels list (#58163) Block Editor: Optimize the 'useBlockDisplayTitle' hook (#58250) Remove noahtallen from .wp-env codeowners (#58283) Global styles revisions: fix is-selected rules from affecting other areas of the editor (#58228) Try: Disable text selection for post content placeholder block. (#58169) Remove `template-only` mode from editor and edit-post packages (#57700) Refactored download/upload logic to support font faces with multiple src assets (#58216) Components: Expand theming support in COLORS (#58097) Implementing new UX for invoking rich text Link UI (#57986) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Based on previous work: #32118 and #40004.
PR optimizes the
useBlockDisplayTitlehook to avoid re-renders when attributes change.The attributes returned from the selector where are used to derive the block title string. This small optimization derives the title inside the selector and prevents unnecessary re-renders.
I have also removed the
useBlockDisplayInformationusage. How hook directly checks variation match title. This should reduce store subscriptions created by the hook.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast